Stabilize CI-build-and-test jobs on Ubuntu Linux 22.04 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts to keep the CI tests runing cleanly. Some tests are failing due to different issues reported under issue #242 and #244. Those will need some minor corrections in build-steps. For now, 5 test-cases from test.sh are commented out with a Warning message. - Skip few simulated-SEV related build-and-test cases. - Skip ISLET-related build-and-test tests due to rustc version incompatibility. Those will need to be re-enabled when above two issues are resolved, if possible. (If further investigation shows that we cannot support Ubunutu 22.04, then some changes will need to be made in CI's build.yml to drop-down to an older Ubuntu rev-level.)
gapisback
force-pushed
the
gapisback/Fix-make-test-build-and-install-sev-snp-simulator
branch
from
20fef6e to
114d4e8
Compare
gapisback
changed the title
gapisback
commented
Apr 25, 2024
| @@ -28,6 +28,10 @@ jobs: | |||
| # Need to resolve references to imports from 'google.protobuf' | |||
| sudo apt install -y python3-protobuf | |||
|
|
|||
| #! ------------------------------------------------------------------------- | |||
| - name: report-osinfo | |||
| run: ./CI/scripts/osinfo.sh | |||
There was a problem hiding this comment.
Somewhat unrelated addition of a shell script to report OS version-level on CI-VM being used.
gapisback
commented
Apr 25, 2024
| @@ -681,7 +681,9 @@ function rm_non_git_files() { | |||
| fi | |||
|
|
|||
| local tmp_islet_dir="/tmp/islet-save" | |||
| mkdir "${tmp_islet_dir}" | |||
| if [ ! -d "${tmp_islet_dir}" ]; then | |||
| mkdir "${tmp_islet_dir}" | |||
There was a problem hiding this comment.
Minor unrelated fix. Re-runs of this script will fail if this dir exists.
gapisback
commented
Apr 25, 2024
| @@ -48,7 +48,7 @@ clean: | |||
| rm -f modules.order Module.symvers Module.markers *.o *.cmd sevnull.ko | |||
| rm -rf keys | |||
|
|
|||
| .PHNOY: | |||
| .PHONY: | |||
bitboom
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to keep the CI tests runing cleanly.
Some tests are failing due to different issues reported under issue #242 and #244.
Those will need some minor corrections in build-steps.
For now, 5 test-cases from test.sh are commented out with a Warning message.
Those will need to be re-enabled when above two issues are resolved, if possible.
(If further investigation shows that we cannot support Ubunutu 22.04, then some changes will need to be made in CI's build.yml to drop-down to an older Ubuntu rev-level.)