Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Rigaku HyPix-Arc detectors #787

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Support for Rigaku HyPix-Arc detectors #787

wants to merge 6 commits into from

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Feb 14, 2025

FormatROD_Arc provides multipanel detector support for the Rigaku HyPix-Arc 100° (2 panel) and 150° (3 panel) detectors. This has been tested on 47 data sets from both detectors, kindly supplied by Christian Göb from Rigaku, covering various goniometer settings. All good data sets could be successfully indexed (the few data sets that did not index looked to be of poorer quality).

"xmax": 800,
"ymax": 775,
"xmin_mm": (385 + gap_px) * pixel_size_x,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these constants available in the image header?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the Windows CAP program gives me useful values, which it suggests are in the header:

psImage->sextra.smultimodule_imgdef
  ixmodules_imgheader: 3
  iymodules_imgheader: 1
  imodule_nx_imgheader: 385
  imodule_ny_imgheader: 775
  imodule_gapx_imgheader: 30
  imodule_gapy_imgheader: 0

I'll try to find them.

Copy link
Member Author

@dagewa dagewa Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These come in a struct called campar_extra_tag, but there may be some seeking between the tags, so I'm not sure if it is contiguous with earlier parts of the header. To find out, I'll have to dig back into the source code

@biochem-fan
Copy link
Member

47 data sets from both detectors, kindly supplied by Christian Göb from Rigaku

Wow. Can you encourage Rigaku to make these test datasets, at least some of them, public?

@dagewa
Copy link
Member Author

dagewa commented Feb 14, 2025

47 data sets from both detectors, kindly supplied by Christian Göb from Rigaku

Wow. Can you encourage Rigaku to make these test datasets, at least some of them, public?

They've agreed to supply a couple of data sets, but fresh ones that are good quality. Once I have them I can add to dials data for a dials.index test

are stored, so read from the header instead of hardcoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants