FormatNXmxEigerFilewriter swap incorrect-looking image dimensions.
#793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the data_size, just check if it looks wrong based on a list of swapped known Eiger data_size values.
|
How about keeping the version-based check within a try block after your hard-coded match, just in case for exotic custom built EIGERs? |
|
I was going for simplicity, but I don't mind to add a version check back in (though it should probably be ahead of the lookup, otherwise I risk two swaps). What does @graeme-winter think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firmware version check introduced in #676 could fail for strange version numbers (for example, development versions) as noted in #790. Rather than relying on a check that could be fragile, this changeset simply swaps the values if they look wrong, based on what we know about Eiger detectors.