-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual pi network #543
Open
hibenj
wants to merge
61
commits into
cda-tum:main
Choose a base branch
from
hibenj:virtual_pi_network
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Virtual pi network #543
Changes from 19 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
73a8d64
:art: experiments_file_cleaned
hibenj 9002bce
:memo: Update pyfiction docstrings
actions-user bb8f9c4
:art: modified traits.hpp
hibenj 3c0ddeb
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj 77b6867
:art: added docs
hibenj 5aec291
:art: small modifications
hibenj d06c3cc
:memo: Update pyfiction docstrings
actions-user a3d07a2
:art: small adjustments
hibenj 55abee5
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj fbe2eec
:memo: Update pyfiction docstrings
actions-user 940c8af
:art: removed deep copy constructing on top of other network types.
hibenj 366e67a
:memo: Update pyfiction docstrings
actions-user 4dce17d
:art: corrected traits and added name_conservation test case
hibenj 9530ef0
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj 68b1eff
:memo: Update pyfiction docstrings
actions-user 93c3baa
:art: docs updated
hibenj 40eb89b
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj 5c462f9
Merge branch 'main' into virtual_pi_network
hibenj 6e5cd4b
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] 5f83617
:art: optimized code coverage and fixed clang-tidy errors
hibenj 4a130c1
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj ddecd61
:art: fixed function forwarding for foreach functions
hibenj 482bb05
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] e4f5499
:art: fixed clang-tidy warnings for std::optional unchecked access
hibenj ba87098
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj c41d1fd
Merge branch 'main' into virtual_pi_network
marcelwa cfb50db
Merge branch 'main' into virtual_pi_network
hibenj 8abbe4f
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj 548380d
:art: improved code coverage
hibenj 90af75c
Merge branch 'main' into virtual_pi_network
hibenj 2863376
:art: removed clang-tidy errors
hibenj 418f8c5
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] 481e0d8
:heavy_plus_sign: virtual_miter added
hibenj da059df
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj 0e82798
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] db97d7f
:heavy_plus_sign: extended_rank_view added
hibenj 5edd332
:memo: Update pyfiction docstrings
actions-user a0637a4
:art: better code consistency and readability
hibenj 0fd7942
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] 41be15f
:memo: Update pyfiction docstrings
actions-user 726a507
:art: clang tidy corrections
hibenj 05c322d
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj 0c88921
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] e835728
Merge branch 'virtual_pi_network' into extended_rank_view
hibenj 14653f2
:memo: Update pyfiction docstrings
actions-user b10e337
:heavy_plus_sign: new depth_view and rank_view implementations.
hibenj 1b920d0
Merge remote-tracking branch 'origin/extended_rank_view' into extende…
hibenj 26d02fc
:memo: Update pyfiction docstrings
actions-user d1a9c04
Merge branch 'main' into extended_rank_view
hibenj 01db414
:memo: Update pyfiction docstrings
actions-user fade0b4
Merge remote-tracking branch 'origin/extended_rank_view' into extende…
hibenj 0a4555e
Merge branch 'main' into virtual_pi_network
hibenj 3259bfb
Merge branch 'extended_rank_view' into virtual_pi_network
hibenj 09fa50f
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] 1cb8605
:art: virtual miter supports update_ranks and update_levels.
hibenj 66c412f
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj adb0893
:art: PI order adjustments
hibenj 35099de
Merge remote-tracking branch 'origin/main'
hibenj 1ba15c0
Merge branch 'main' into virtual_pi_network
hibenj bdc630e
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] dd980d2
:memo: Update pyfiction docstrings
actions-user File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
Technology Network | ||
================== | ||
Comment on lines
+1
to
+2
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be "Virtual PI Network" or similar, right? |
||
|
||
A logic network type that extends any ``mockturtle`` logic network. It enables copies of PIs, called virtual PIs. | ||
Virtual PIs are created by passing an existing ``real_pi`` to the ``create_virtual_pi`` function. This function | ||
calls the ``create_pi`` function of the extended network and stores the newly created ``virtual_pi`` in a node map, | ||
which maps it to the originating ``real_pi``. Additionally, ``delete_virtual_pis`` returns a network with all | ||
``virtual_pi`` nodes removed and reassigns the edges connected to them to the corresponding ``real_pi`` node stored in | ||
the ``node_map``. | ||
|
||
.. tabs:: | ||
.. tab:: C++ | ||
**Header:** ``fiction/networks/virtual_pi_network.hpp`` | ||
|
||
.. doxygenclass:: fiction::virtual_pi_network | ||
:members: | ||
|
||
.. tab:: Python | ||
.. autoclass:: mnt.pyfiction.virtual_pi_network | ||
:members: |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your other classes and functions should also be documented, i.e.,
virtual_miter
,extended_rank_view
, anddelete_virtual_pis