✅ Added test for issue #667 #668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_quickexact.py
Fixed
Show fixed
Hide fixed
bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_quickexact.py
Fixed
Show fixed
Hide fixed
bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_quickexact.py
Fixed
Show fixed
Hide fixed
bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_quickexact.py
Fixed
Show fixed
Hide fixed
Drewniok
reviewed
Feb 19, 2025
| @@ -75,6 +81,62 @@ def test_perturber_and_sidb_pair_111(self): | |||
| self.assertEqual(groundstate[0].get_charge_state((2, 0)), sidb_charge_state.NEUTRAL) | |||
| self.assertEqual(groundstate[0].get_charge_state((3, 0)), sidb_charge_state.NEGATIVE) | |||
|
|
|||
| def test_simulate_all_inputs_of_and_gate(self): | |||
There was a problem hiding this comment.
Suggested change
| def test_simulate_all_inputs_of_and_gate(self): | |
| def test_simulate_all_inputs_of_AND_gate(self): |
?
| physical_parameters.base = 2 | ||
| physical_parameters.epsilon_r = 5.6 | ||
| physical_parameters.lambda_tf = 5.0 # (nm) | ||
| physical_parameters.mu_minus = ( |
There was a problem hiding this comment.
Why do you use brackets () here?
There was a problem hiding this comment.
Can you please add types for input, output, and logic cells?
Should we mention in the file name that we are talking about the Bestagon AND gate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a test to try to catch the failure described in #667 .
Checklist: