Update run_e2e_test.py to upload required drivers for non-module based repositories. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnsP
approved these changes
Jan 12, 2024
Vipinofficial11
force-pushed
the
bqmt
branch
2 times, most recently
from
d30db5a
to
e055da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement - JDBC Drivers are uploaded based on the specific modules mentioned in driver_details.yaml and if any repository is not a module based repository then driver upload will be skipped.
We have a use case where we need MySQL driver for a non-module based repository (Google-Cloud).
Fix - Created a method to read and upload drivers and re-used that method to upload MySQL driver for only BigQuery Multi Table submodule.
Validations - Tested the logic on self hosted runners specifically for BQMT.