Integration tests for deduplicate and groupby in bq pushdown #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test for connection support in bq transformation pushdown
test for connection support in bq transformation pushdown
fernst
reviewed
Mar 16, 2022
| @@ -162,6 +162,7 @@ private void createProfile(String profileName) throws Exception { | |||
| properties.add(ofProperty("stackdriverLoggingEnabled", "true")); | |||
| properties.add(ofProperty("stackdriverMonitoringEnabled", "true")); | |||
| properties.add(ofProperty("idleTTL", "60")); | |||
| properties.add(ofProperty("imageVersion", "2.0.25-debian10")); | |||
There was a problem hiding this comment.
I don't think we should force any given image for Dataproc tests
There was a problem hiding this comment.
somehow this addition is from a previous commit, several commits are squashed in this one. I'll try to fix that
sanjanasandeep
force-pushed
the
bq-aggns
branch
2 times, most recently
from
40d8a33
to
23046e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.