Add new tab for Service accounts in Namespace admin UI #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radhikav1
force-pushed
the
nsisolation/securtytab
branch
4 times, most recently
from
9a7f50e
to
5abf3ec
Compare
radhikav1
force-pushed
the
nsisolation/securtytab
branch
3 times, most recently
from
cb29d11
to
4c61891
Compare
radhikav1
requested review from
njbriggs,
GnsP,
itsankit-google and
sumengwang
radhikav1
force-pushed
the
nsisolation/securtytab
branch
4 times, most recently
from
2fdadee
to
d8fdc8a
Compare
GnsP
requested changes
Sep 27, 2023
app/cdap/components/NamespaceAdmin/ServiceAccounts/EditConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
app/cdap/components/NamespaceAdmin/ServiceAccounts/EditConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
app/cdap/components/NamespaceAdmin/ServiceAccounts/DeleteConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
app/cdap/components/NamespaceAdmin/ServiceAccounts/DeleteConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
app/cdap/components/NamespaceAdmin/ServiceAccounts/EditConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
app/cdap/components/NamespaceAdmin/ServiceAccounts/EditConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
app/cdap/components/NamespaceAdmin/ServiceAccounts/EditConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
app/cdap/components/NamespaceAdmin/ServiceAccounts/EditConfirmDialog.tsx
Show resolved
Hide resolved
seanfeld
reviewed
Sep 27, 2023
app/cdap/components/NamespaceAdmin/ServiceAccounts/EditConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
seanfeld
reviewed
Sep 27, 2023
app/cdap/components/NamespaceAdmin/ServiceAccounts/EditConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
seanfeld
reviewed
Sep 27, 2023
seanfeld
reviewed
Sep 27, 2023
sumengwang
reviewed
Sep 27, 2023
GnsP
requested changes
Sep 29, 2023
app/cdap/components/NamespaceAdmin/ServiceAccounts/EditConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
radhikav1
force-pushed
the
nsisolation/securtytab
branch
from
d8fdc8a
to
b472af4
Compare
GnsP
requested changes
Oct 3, 2023
app/cdap/components/NamespaceAdmin/ServiceAccounts/EditConfirmDialog.tsx
Show resolved
Hide resolved
radhikav1
force-pushed
the
nsisolation/securtytab
branch
from
848024c
to
8ba5cd4
Compare
radhikav1
commented
Oct 3, 2023
| setIsExpanded(false); | ||
| }, [statusMessage]); | ||
|
|
||
| const showStatusMessage = () => { |
There was a problem hiding this comment.
Moved this is separate child component named Status under ConfirmDialog to avoid useEffect usage
GnsP
approved these changes
Oct 3, 2023
sumengwang
approved these changes
Oct 4, 2023
radhikav1
force-pushed
the
nsisolation/securtytab
branch
from
8ba5cd4
to
071bdad
Compare
radhikav1
force-pushed
the
nsisolation/securtytab
branch
from
071bdad
to
17308c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new tab for Service accounts in Namespace admin UI
Description
Add new tab for Service accounts in Namespace admin UI
PR Type
Links
Jira: CDAP-20821
Test Plan
Screenshots
Service account's Edit and Delete options in Namespace admin - Service accounts tab
Add Service account button when no service account is associated with namespace
Edit\Add dialog with help content and copy option for gCloud command
Gcloud command with Identity & Service account filled automatically
Delete service account dialog
Dialog when error occurred
