Add new component for confirmation dialog #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radhikav1
force-pushed
the
newux/confirmdialog
branch
from
d877259 to
feb8d99
Compare
GnsP
reviewed
Sep 6, 2023
sumengwang
reviewed
Sep 6, 2023
| size="small" | ||
| onClick={handleToggleExtendedMessage} | ||
| color="inherit" | ||
| title={isExpanded ? 'Hide details' : 'Show details'} |
There was a problem hiding this comment.
Here title is html attribute and not allowed to give other than strings. Suggest me if there is any other way?
njbriggs
reviewed
Sep 6, 2023
radhikav1
force-pushed
the
newux/confirmdialog
branch
from
9ff3be9 to
7031c5b
Compare
GnsP
approved these changes
Sep 12, 2023
sumengwang
approved these changes
Sep 12, 2023
njbriggs
approved these changes
Sep 12, 2023
seanfeld
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new component for confirmation dialog
Description
Add new component for confirmation dialog using react material components.
PR Type
Links
Jira: CDAP-20796
Test Plan
N/A
Screenshots
Confirm dialog with confirmation text
Confirm dialog with Error message
Confirm dialog with Error message and more details expanded
