Explain client limitations for non-2XX error codes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not being able to correctly decode responses with a non-2XX status code in servant-client is an important limitation that should be mentioned in the README as already suggested in issue #27.
|
Thanks a lot for updating this as well.
I'll be very interested in seeing if you can come up with something good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was suggested in issue #27, I added a few lines to the README describing the problem of servant-client swallowing non-2XX HTTP response codes.
I also added similar comments to the relevant parts of the example API and the docstring for
ErrStatus.Not sure what to do about the instructions for running the example client in the README. They suggest the client would correctly return e.g.
the search term was not "Hello", which is not true. Maybe we can leave it for now and focus on fixing the source of the problem instead. I will see if I can find a way to changeservant-clientwithout causing too much breakage.