Improve handling of subdirs for git extra-deps #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry I haven't gotten to this yet. I think this looks interesting, but I haven't really be able to do an in-depth review. I might not be able to really get to this for another month or so. Sorry to keep you waiting longer! |
|
Hey, sorry I haven't gotten to this yet. I think this looks like a good fix, but I haven't really be able to do an in-depth review. I might not be able to really get to this for another month or so. Sorry to keep you waiting! |
That's ok! This doesn't have super high priority for me either. But thanks for letting me know. |
|
Thanks for figuring this out! I've rebased this in #56. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of copying the subdir, we now instruct cabal2nix to focus on the subdir using
--subpath, so that if the build depends on anything outside the subdir, that's still available.Closes #45.