Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is a nice project you have and I would love to contribute...
I noticed the docs for face landmarking have not quite as robust of an interface as the pose detection and wanted to try and bring them to parity.
When I tried out the example face landmarking project it crashed a little bit for me and so I tried to improve the performance using similar patterns as the pose detection example, such as using reanimated 3. You might not want this, or you might want it in a different way so I'm happy to adjust the contribution based on your priorities. Right now, if you download this branch it will have an updated example project for iOS that improves performance of the drawn facemesh and exposes some more features like FPS throttling and device/sensor orientation/forcing as in the pose detection module.
Please be aware, there is no android code yet, only iOS. I tried getting the examples working on android emulators and get stuck on this runtime error for all example projects at the moment:
It is my first time creating a react-native module for android so it is probably for some stupid fault of mine but I will keep learning...
Anyway, the purpose of opening this incomplete merge request is to ask if you would be open to a contribution in this direction and if so do you have any advice or comments based on these two commits? I saw the recent release so maybe you're already doing something along these lines or the project has other significant developments.
Thanks again for creating this, hope to be able to help.