-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: work-around long path issues on windows #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the ios build is failing. It might not be you
Yeah - I didn't touch the ios build at all (not that that's fullproof). If I'm reading the logs correctly, the error is
I've noticed when building the ios version of the example that I end up with changes to |
Where are you seeing these log errors? I guess they are in the raw logs, is that how you found them? |
The error is in the raw log file at line 46839. However, I found it by downloading the log archive (available from the gear icon from the build-ios results. That gave me a zip with more structured logs and I was able to drill down to the I just noticed that #61 failed the same job. And checking the log archives, it is failing in the same way, so it looks like we've got an intermittent error in our CI process (yuck). I'll do some digging on this today, but let me know if it's all right to run this job again to see what happened (I think you said there is a monetary cost per run)... |
If this SO answer is accurate, it looks like this error stems from One thing we could try is disabling one or both of those caches in the build system and see if this intermittent error disappears (we'd probably have to leave them off for a while). I'm not familiar enough with these systems to know what and how much we're getting out of these caches (probably build speed, but maybe it's cheaper as well)? |
Create a monkey-patch to get around the long filename issues on windows in the example. If I understand how the yarn patch works, we shouldn't have to do this for each example, but we'll probably want to document this and/or do a round with the react-native-vision-camera folks to see if they are willing to fix this on their end.
The core of the patch is to use a custom build of ninja.exe and tell it that we can have long path names. In order for this to work, you need to first enable long paths on windows. The quick way to do that is to run this reg file as admin and reboot.
The changes in the gradle file are under Windows-only build flags. I verified that it works on both Windows and Mac (and I verified that it failed on mac if I didn't put in the protection.