contributing.md #55
Merged
contributing.md #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdiddy77
reviewed
Apr 20, 2024
CONTRIBUTING.md
Outdated
Comment on lines
13
to
23
| iOS: | ||
| XCode | ||
| Node & Watchman using Homebrew. | ||
| - brew install node | ||
| - brew install watchman | ||
| Cocopod | ||
| - $ sudo gem install cocoapods. | ||
|
|
||
| Andriod: | ||
| Android development environment. | ||
| Java Development Kit - Zulu using Homebrew. |
There was a problem hiding this comment.
this isn't necessary. These sorts of packages all assume that users have already set up a react native development environment.
|
Also note: the "issue" work item complains about another issue. |
cdiddy77
requested changes
Apr 23, 2024
|
I will make changes. I got some answers from Robert.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Charles P ***@***.***>
Sent: Tuesday, April 23, 2024 10:26:55 AM
To: cdiddy77/react-native-mediapipe ***@***.***>
Cc: sukanvisapearyoo ***@***.***>; Author ***@***.***>
Subject: Re: [cdiddy77/react-native-mediapipe] contributing.md (PR #55)
@cdiddy77 requested changes on this pull request.
This change isn't really necessary -- as noted, the inserted lines are not needed. Should we close this PR or were there other changes you wanted to make?
—
Reply to this email directly, view it on GitHub<#55 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A326HSIANS4N2HAUWEO77HTY62KV7AVCNFSM6AAAAABGQCORBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJXHA3DCMJRGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
rorleth
reviewed
Apr 24, 2024
CONTRIBUTING.md
Outdated
| @@ -37,7 +24,7 @@ Read the READMEs in [`android/`](android/README.md) and [`ios/`](ios/README.md) | |||
|
|
|||
| ### iOS | |||
|
|
|||
| 1. Open the `react-native-mediapipe/example/ios/MediapipeExample.xcworkspace` file with Xcode | |||
| 1. Open the `react-native-mediapipe/examples/ios/MediapipeExample.xcworkspace` file with Xcode | |||
There was a problem hiding this comment.
That is still not the correct path - there is a folder called objectdetection under /examples/ and the xcworkspace file is called differently.
rorleth
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(contributing): Modified the 'Get Started' section by adding iOS and android 'Install dependencies' part