Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write publishing timestamps to SSM #1773

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 18, 2024

Add a feature to allow publishing the latest published version and its timestamp to SSM, so that we can start tracking how long it takes to replicate, and alarm at a different severity if a canary fails and we recently released.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Add a feature to allow publishing the latest published version and its
timestamp to SSM, so that we can start tracking how long it takes to
replicate, and alarm at a different severity if a canary fails
and we recently released.
@rix0rrr rix0rrr requested a review from a team November 18, 2024 12:29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we have this script in a single place?

Copy link
Contributor Author

@rix0rrr rix0rrr Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not trivially -- the way the assets are packed means it just uses the specific publishing directory.

We could go for a build step to copy a bunch of files into a specific directory, but since bash doesn't have a way to find or specify directories, it would all be quite magical. The publishing scripts would invoke another script that's not there from the PoV of the calling script (but will be there at runtime because it will have been copied).

If you have a good idea I'm all ears

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see the problem. Would it make sense to at least have a build step to make sure they are all identical?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants