Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade jsii rosetta dependency #1646

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: upgrade jsii rosetta dependency #1646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa033c8
test: support process.execPath with spaces
aripalo Nov 19, 2024
d6dc3f5
build: add jsii-rosetta 5.6.0 as peer dependency
aripalo Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .projen/deps.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .projenrc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ new RosettaPeerDependency(project, {
[RosettaVersionLines.V5_3]: '~5.3.0',
[RosettaVersionLines.V5_4]: '~5.4.0',
[RosettaVersionLines.V5_5]: '~5.5.0',
[RosettaVersionLines.V5_6]: '~5.6.0',
},
});

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions projenrc/rosetta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export enum RosettaVersionLines {
V5_3,
V5_4,
V5_5,
V5_6,
}

export interface RosettaPeerDependencyOptions {
Expand Down
12 changes: 6 additions & 6 deletions test/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ test('construct-library', () => {
const fixture = join(`${__dirname}/__fixtures__/libraries/${libraryName}`);

// generate the documentation
execSync(`${process.execPath} ${cli}`, { cwd: fixture });
execSync(`"${process.execPath}" ${cli}`, { cwd: fixture });

const md = readFileSync(join(fixture, 'API.md'), 'utf-8');
expect(md).toMatchSnapshot();
Expand All @@ -23,7 +23,7 @@ test('specify language', () => {
const fixture = join(`${__dirname}/__fixtures__/libraries/${libraryName}`);

// generate the documentation
execSync(`${process.execPath} ${cli} --language python`, { cwd: fixture });
execSync(`"${process.execPath}" ${cli} --language python`, { cwd: fixture });

const md = readFileSync(join(fixture, 'API.md'), 'utf-8');
expect(md).toMatchSnapshot();
Expand All @@ -36,7 +36,7 @@ test('specify submodule', () => {
const fixture = join(`${__dirname}/__fixtures__/libraries/${libraryName}`);

// generate the documentation
execSync(`${process.execPath} ${cli} --submodule submod1`, { cwd: fixture });
execSync(`"${process.execPath}" ${cli} --submodule submod1`, { cwd: fixture });

const md = readFileSync(join(fixture, 'API.md'), 'utf-8');
expect(md).toMatchSnapshot();
Expand All @@ -49,7 +49,7 @@ test('specify root submodule', () => {
const fixture = join(`${__dirname}/__fixtures__/libraries/${libraryName}`);

// generate the documentation
execSync(`${process.execPath} ${cli} --submodule root`, { cwd: fixture });
execSync(`"${process.execPath}" ${cli} --submodule root`, { cwd: fixture });

const md = readFileSync(join(fixture, 'API.md'), 'utf-8');
expect(md).toMatchSnapshot();
Expand All @@ -63,7 +63,7 @@ test('split-by-submodule creates submodule files next to output', () => {
const fixture = join(`${__dirname}/__fixtures__/libraries/${libraryName}`);

// generate the documentation
execSync(`${process.execPath} ${cli} --output=docs/API.md --split-by-submodule`, { cwd: fixture });
execSync(`"${process.execPath}" ${cli} --output=docs/API.md --split-by-submodule`, { cwd: fixture });

const rootMd = readFileSync(join(fixture, 'docs/API.md'), 'utf-8');
const submoduleMd = readFileSync(join(fixture, 'docs/submod1.md'), 'utf-8');
Expand All @@ -83,7 +83,7 @@ test('specify languages and split-by-submodule creates submodule files next to o
const fixture = join(`${__dirname}/__fixtures__/libraries/${libraryName}`);

// generate the documentation
execSync(`${process.execPath} ${cli} --output=docs/API.md --split-by-submodule -l typescript -l python`, { cwd: fixture });
execSync(`"${process.execPath}" ${cli} --output=docs/API.md --split-by-submodule -l typescript -l python`, { cwd: fixture });

// TypeScript
const rootTs = readFileSync(join(fixture, 'docs/API.typescript.md'), 'utf-8');
Expand Down
66 changes: 27 additions & 39 deletions yarn.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.