Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to previous hotfixes and go mod tidy #5

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jtagcat
Copy link

@jtagcat jtagcat commented Nov 22, 2021

  • So turns out only some tags:[] in the JSON are map[int]string, some are still []string. Made corrections.
  • Added comments to the hotfix of bools hiding in strings.
    • I'll see if I have time, I'll look in to implementing a proper fix for that; likely won't. (Something similar to this)
  • go mod tidy

Please also do tag (a release) after merge.

@jtagcat
Copy link
Author

jtagcat commented Nov 23, 2021

hmph, it seems that maybe some requests use the id-less format, others do use the id for tags; so adding a commit:

  • uhh use duplicated struct with map[id]string in some places (atm only getTorrent)
  • also added a tiny optimization/refactor, as seen in the second commit

...in a (almost totally) different way than other times

same workarounds might be needed for other calls/types
 - the empty filelist check was previously done twice
 - parseFileList() doesn't need to, and thus
     shouldn't be published outside the package (use Files())
 - t.files doesn't need to be redeclared or moved to a different var
upstream changed, so we adapt dumbly
there should be actual conversion of one format to the other..

follow-up to commit 327f988
Backoff might need some further tuning
@jtagcat
Copy link
Author

jtagcat commented Dec 11, 2021

@charles-haynes can I haz write access to repo? :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant