Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support shorter 'Given failing s2i build…' #74

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Support shorter 'Given failing s2i build…' #74

merged 1 commit into from
Mar 5, 2025

Conversation

jmtd
Copy link
Collaborator

@jmtd jmtd commented Jan 27, 2025

Let the user omit "using {tag}", since tag defaults to master.

@jmtd
Support shorter 'Given failing s2i build…'
4c0b50f 
Let the user omit "using {tag}", since tag defaults to master.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd mentioned this pull request Jan 27, 2025
Merged
rnc
rnc approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@rnc rnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. And def s2i_build has similar support.

@rnc rnc merged commit 2a5c755 into cekit:v1 Mar 5, 2025
1 check passed
@rnc rnc mentioned this pull request Mar 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnc rnc rnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmtd @rnc