Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Resolving TypeError, during version unpacking " #2225

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Jan 15, 2025

Reverts #2098

might need to revisit this

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.54%. Comparing base (5d95b64) to head (01aebf5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kombu/utils/text.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2225      +/-   ##
==========================================
+ Coverage   81.51%   81.54%   +0.03%     
==========================================
  Files          77       77              
  Lines        9526     9517       -9     
  Branches     1153     1154       +1     
==========================================
- Hits         7765     7761       -4     
+ Misses       1569     1564       -5     
  Partials      192      192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy auvipy requested a review from Nusnus February 16, 2025 05:14
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the original PR was merged without waiting for our proper review, so with additional errors this is indeed prompt for revert.

@Nusnus Nusnus marked this pull request as ready for review February 16, 2025 12:30
@Nusnus Nusnus merged commit 8931c50 into main Feb 16, 2025
42 checks passed
@Nusnus Nusnus deleted the revert-2098-bugfix/type-error-version-checking branch February 16, 2025 12:30
@auvipy
Copy link
Member Author

auvipy commented Feb 16, 2025

yes exactly

@auvipy auvipy added this to the 5.5.0 milestone Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants