chore(mypy): switch to pyproject.toml configuration
#2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches `mypy` configuration from `setup.cfg` to `pyproject.toml`. How this has been tested? - `pyproject.toml` configuration is correctly read, cf. `mypy -vvv .` output. - pre-commit works as before.
stegayet
commented
Jan 27, 2025
| @@ -142,7 +142,7 @@ commands = | |||
| pydocstyle {toxinidir}/kombu | |||
|
|
|||
| [testenv:mypy] | |||
| commands = python -m mypy --config-file setup.cfg | |||
| commands = python -m mypy | |||
There was a problem hiding this comment.
There is no need to specify config-file CLI option as mypy automatically searches for configuration file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2233 +/- ##
=======================================
Coverage 81.50% 81.50%
=======================================
Files 77 77
Lines 9524 9524
Branches 1152 1152
=======================================
Hits 7763 7763
Misses 1569 1569
Partials 192 192 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2232.
Description
This commit switches
mypyconfiguration fromsetup.cfgtopyproject.toml.How this has been tested?
pyproject.tomlconfiguration is correctly read and same as before, cf.mypy -vvv .output.