Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-build fails for DockerHub and Scaleway on PRs from forks #93

Closed
rootulp opened this issue Feb 5, 2024 · 0 comments · Fixed by #94
Closed

docker-build fails for DockerHub and Scaleway on PRs from forks #93

rootulp opened this issue Feb 5, 2024 · 0 comments · Fixed by #94
Assignees
@MSevey
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Comments

@rootulp
Copy link
Contributor

rootulp commented Feb 5, 2024

Context

celestia-app just upgraded to v0.3.1 of this repo.

Problem

CI fails for docker-build to DockerHub and Scaleway with:

Error: Username and password required

Link: https://github.com/celestiaorg/celestia-app/actions/runs/7789514729/job/21241591600?pr=3071#step:3:11

Proposal

Skip this task if the workflow is expected to fail. I think it's expected to fail for PRs created from forks cc: @MSevey
@MSevey MSevey self-assigned this Feb 5, 2024
@MSevey MSevey added enhancement New feature or request github_actions Pull requests that update GitHub Actions code and removed needs: triage labels Feb 5, 2024
@MSevey MSevey mentioned this issue Feb 5, 2024
Merged
5 tasks
@MSevey MSevey closed this as completed in #94 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSevey MSevey

Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix failing docker CI due to permission issues on PRs MSevey/celestia-.github
2 participants
@rootulp @MSevey