fix: fix failing docker CI due to permission issues on PRs #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
changed the title
…n them on merge events
|
[nit] I think the PR title may have meant to use the conventional commit prefix |
rootulp
previously approved these changes
Feb 5, 2024
MSevey
changed the title
MSevey
commented
Feb 5, 2024
Co-authored-by: Rootul P <[email protected]>
This was referenced Feb 5, 2024
Bidon15
previously approved these changes
Feb 6, 2024
MSevey
commented
Feb 6, 2024
Bidon15
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #93
This change skips running the dockerhub and scaleway runs when it is a PR.
We use org level secrets for logging into dockerhub and scaleway, and these secretes are only accessible by native branches, or users with write access.
This means that on PRs from forks or non team members, the runs would fail.
These still pass on main on merge, because at that point, the permission issue is no longer present.
Additional this change removes the appended hash to the action run, which causes issues with linking the action to the branch protection rules.
Verified and tested: https://github.com/celestiaorg/.github/actions/runs/7790602743
Checklist