CIP to introduce authored blobs

[cmwaters]

This CIP is in reference to this issue: celestiaorg/celestia-app#3316

Note that there is a diagram so when changing the name of the file and folders, make sure to change the name of the folder in the assets directory and update this CIP that references it

[evan-forbes]

still chewing but otherwise LGTM!

[nashqueue]

Maybe we should add the fact that you need versioning for the CreateCommitment function. As we might be adding other things in the future which will change the shares and therefore the share commitment.

Create commitment will now have to be aware of the signer.

[rootulp]

Thanks for including the diagram!

[cmwaters]

Maybe we should add the fact that you need versioning for the CreateCommitment function. As we might be adding other things in the future which will change the shares and therefore the share commitment.

Create commitment will now have to be aware of the signer.

The CreateCommitment function has the following signature:

func CreateCommitment(blob *blob.Blob, merkleRootFn MerkleRootFn, subtreeRootThreshold int) ([]byte, error) 

As it includes the blob, which has the signer as well as the share version, I don't think anything will need to change to the function signature. Of course within the function, the commitment construction will depend on whether the signer is present in the blob or not

[mastergaurang94]

(Disclaimer: I'm a newb) what do you mean? Aren't the blobs returned guaranteed to be included?

[jcstein]

LGTM, but would like to resolve the open discussions before merging

[cmwaters]

@jcstein all comments should be resolved now

[rootulp]

Assigned this CIP-21. FYI @jcstein