-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: site with mdbook #170
Conversation
Options for frontmatter: 1. change the styling to have backticks around it and display the code block2. change the style of the frontmatter itself to be .md-friendly instead of github-flavored-markdown friendly3. use GFM-styled table
|
fix: linting fix: resolve conflicts fix: add cip: 23 to frontmatter fix: conflicts
demo: https://cips.jcstein.dev/ once this is approved, 2 things will need to happen before going live:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks for all your hard work on this!
GFM style tables look very annoying to edit for CIP authors and look worse rendered to me. Why do you think it looks worse than option 2? |
I think options 2 and 3 are equally as annoying to edit/author and neither is perfect. GFM just fits into the current style that is displayed on github |
I don't follow how, as option 2 just requires the author to write bulletpoints whereas option 3 requires them to add a bunch of ------ ascii art and scroll right to see the whole text, and disable text wrap |
I see, the table for option 2 is easier to edit. i will demo on this PR
renders:
|
Overview
TODO
The previous PR got too messy and I'd like to try without moving the structure around. #168