Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull README.md into CIPs dir, fix CC0 links, add dropdown for CIPs #179

Merged
merged 16 commits into from
Jul 22, 2024

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Jul 22, 2024

Overview

Resolves #176
Resolves #177
Resolves #178

NOTE: links that are in format of *.html are so that the site works. Known issue that they don't work on Github natively. But the site works.

https://github.com/jcstein/CIPs/blob/550a240fd01c0a80a7134eae9bc5fe9e487014c1/cips/README.md?plain=1#L5
https://github.com/jcstein/CIPs/blob/550a240fd01c0a80a7134eae9bc5fe9e487014c1/cips/wgs/README.md?plain=1#L6-L10

@jcstein
Copy link
Member Author

jcstein commented Jul 22, 2024

it would also be possible to rename LICENSE to LICENSE.md and it should work, but when I renamed it, and tried to link it from (./LICENSE.md) or (../LICENSE.md) or (./../LICENSE.md) it failed similarly to the way I hit issues with:

NOTE: links that are in format of *.html are so that the site works. Known issue that they don't work on Github natively. But the site works.

https://github.com/jcstein/CIPs/blob/550a240fd01c0a80a7134eae9bc5fe9e487014c1/cips/README.md?plain=1#L5
https://github.com/jcstein/CIPs/blob/550a240fd01c0a80a7134eae9bc5fe9e487014c1/cips/wgs/README.md?plain=1#L6-L10

so i think for now linking to CC0 on github is the cleanest UX.

@jcstein jcstein removed the request for review from YazzyYaz July 22, 2024 18:50
@jcstein jcstein self-assigned this Jul 22, 2024
cips/README.md Outdated Show resolved Hide resolved
@jcstein jcstein merged commit 0301c23 into celestiaorg:main Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants