Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cip for tx limits #226

Merged
merged 7 commits into from
Oct 19, 2024
Merged

docs: cip for tx limits #226

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
921a589
docs: cip for tx limits
jcstein Oct 17, 2024
8983582
docs: edits
jcstein Oct 17, 2024
66de5cf
docs: add original context from previous PR
jcstein Oct 17, 2024
ffc87f3
Merge branch 'main' into jcs/tx-limit
jcstein Oct 18, 2024
8d435fa
docs: name to cip-28.md
jcstein Oct 18, 2024
8506c2d
docs: add to CIP-25
jcstein Oct 18, 2024
52a5281
Apply suggestions from code review
jcstein Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions cips/cip-tx-limits.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
| cip | TBD(28) |
| - | - |
| title | Transaction size limit |
| description | Set limit for transaction size |
| author | Josh Stein ([@jcstein](https://github.com/jcstein)), Nina Barbakadze ([@ninabarbakadze](https://github.com/ninabarbakadze)), Rootul Patel ([@rootulp](https://github.com/rootulp)) |
| discussions-to | <https://forum.celestia.org/t/cip-limit-number-of-pfbs-and-non-pfbs-per-block-increase-transaction-size-limit/1843> |
| status | Draft |
| type | Standards Track |
| category | Core |
| created | 2024-10-16 |

## Abstract

This CIP proposes to set the limit for transaction size. The proposal is to set the transaction size limit to 2MiB. Setting the transaction size limit is consensus-breaking.

## Specification

1. Transaction size is limited to 2MiB by setting the versioned parameter `MaxTxSize` to 2097152, which is 2MiB in bytes. From version v3 and above, in `CheckTx`, `PrepareProposal`, and `ProcessProposal`, each transaction's size is checked against the `appconsts.MaxTxSize` threshold. This ensures that transactions over the limit are rejected or excluded at all stages, from initial submission to execution.

## Rationale

The rationale for this proposal is to set the transaction size limit to 2MiB, even with 8MiB blocks, to prevent issues with gossiping large transactions. Gossiping an 8MiB transaction without chunking could be detrimental to the network. This is a consensus-breaking change.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ninabarbakadze can you elaborate here on why we implemented this as a consensus breaking change instead of modifying the default mempool MaxTxBytes to 2 MiB?

I asked about it in a few places (Slack) and celestiaorg/celestia-app#3686 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait on feedback until tomorrow and plan to get draft in then. Thank you @ninabarbakadze and @rootulp !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because every node can set the default to any value they choose to and afaik we don't know the effect large transactions are going to have on the network so in my understanding it's preventative. cc @evan-forbes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed the motivation for the change is preventative.

because every node can set the default to any value they choose to

Nodes can override the default but I expect most nodes will use the default. Assuming most nodes use the default config, transactions larger than 2 MiB won't be included in blocks so blob submitters will continue submitting blobs <= 2 MiB so that their blobs get included in blocks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you but it seemed like we wanted to have a hard limit on it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I'm wondering why did we want the hard limit? The non-consensus breaking change is still preventative.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested revision below: #226 (comment)


## Backwards Compatibility

This proposal is meant to be included with v3 and the [Ginger Network Upgrade](./cip-25.md). It is a consensus-breaking change.

## Security Considerations

This proposal does not introduce any new security risks. However, it does impact network behavior and user experience, which should be carefully considered during implementation.

## Copyright

Copyright and related rights waived via [CC0](https://github.com/celestiaorg/CIPs/blob/main/LICENSE).