docs: remove index.html links in top level wg README links #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…README.md will be automatically detected and rendered in GitHub UI
rootulp
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Thanks Ramin!
I confirmed this works when I run the CIPs site locally and tried the links.
The relative links don't work in the Github preview of the Markdown file but I expect them to work after this PR merges b/c currently they redirect to https://github.com/celestiaorg/CIPs/blob/ramin/update-wg-links/cips/wgs/da and the /blob/ramin/update-wg-links portion won't exist after merging it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While digging around the CIPs repo looking to catch up on what i'd missed the last few months, i noticed there was a front
READMElink to the wgs which acted as a landing page, that then linked to each folder for each WG, but those were set as "index.html" and thus would 404 in GitHub.I've updated the top level /wg/README to link to each WG's folder where GitHub automatically will render the main README.md
eg: https://github.com/ramin/CIPs/blob/ramin/update-wg-links/cips/wgs/README.md