Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP 18: Add tx priority to requests #244

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

cmwaters
Copy link
Contributor

This PR makes a few minor modifications to CIP 18: Standardised Gas and Pricing Estimation Interface

  • Remove the reference implementation section. Client and server implementations in the light and consensus node respectively will have their own ADRs that eventually can be linked in this CIP
  • Add an optional TxPriority field to indicate the urgency for a transaction to be finalized in a block. It has three levels: low, medium, and high.
  • Modify the APIs to have two methods: requesting just the gas price and requesting the gas price and the gas. The latter will be used for non-PFB transactions.

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation related questions that can be moved to an ADR if desired

cips/cip-18.md Show resolved Hide resolved
cips/cip-18.md Outdated Show resolved Hide resolved
cips/cip-18.md Outdated Show resolved Hide resolved
cips/cip-18.md Show resolved Hide resolved
cips/cip-18.md Outdated Show resolved Hide resolved
cips/cip-18.md Outdated Show resolved Hide resolved
@cmwaters cmwaters requested a review from rootulp January 17, 2025 08:55
@cmwaters cmwaters requested review from rach-id and vgonkivs January 17, 2025 08:59
@rootulp rootulp merged commit de0a8cb into celestiaorg:main Jan 20, 2025
2 checks passed
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants