Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
review feedback

Co-authored-by: Rootul Patel <[email protected]>
  • Loading branch information
evan-forbes and rootulp authored Aug 25, 2022
1 parent 721e31e commit a22a810
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions pkg/shares/message_shares_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ func Test_parseMsgShares(t *testing.T) {

for _, tc := range tests {
tc := tc
// run the tests with identically sized messagses
t.Run(fmt.Sprintf("%s idendically sized ", tc.name), func(t *testing.T) {
// run the tests with identically sized messages
t.Run(fmt.Sprintf("%s identically sized ", tc.name), func(t *testing.T) {
rawmsgs := make([]coretypes.Message, tc.msgCount)
for i := 0; i < tc.msgCount; i++ {
rawmsgs[i] = generateRandomMessage(tc.msgSize)
Expand All @@ -52,7 +52,7 @@ func Test_parseMsgShares(t *testing.T) {
t.Error(err)
}

// check that the namesapces and data are the same
// check that the namespaces and data are the same
for i := 0; i < len(msgs.MessagesList); i++ {
assert.Equal(t, msgs.MessagesList[i].NamespaceID, parsedMsgs[i].NamespaceID)
assert.Equal(t, msgs.MessagesList[i].Data, parsedMsgs[i].Data)
Expand Down
2 changes: 1 addition & 1 deletion pkg/shares/split_contiguous_shares.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type ContiguousShareSplitter struct {
namespace namespace.ID
}

// NewContiguousShareSplitter returns a ContigousShareWriter using the provided
// NewContiguousShareSplitter returns a ContiguousShareSplitter using the provided
// namespace.
func NewContiguousShareSplitter(ns namespace.ID) *ContiguousShareSplitter {
pendingShare := NamespacedShare{ID: ns, Share: make([]byte, 0, consts.ShareSize)}
Expand Down

0 comments on commit a22a810

Please sign in to comment.