Skip to content

Commit

Permalink
clarifies some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
staheri14 committed Oct 8, 2024
1 parent 8fa70a3 commit b86606c
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions app/test/timeouts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func (s *TimeoutTestSuite) SetupSuite() {
func (s *TimeoutTestSuite) TestConfigTimeoutsOverride() {
t := s.T()

require.NoError(t, s.cctx.WaitForBlocks(2))
require.NoError(t, s.cctx.WaitForBlocks(1))

tmNode := s.cctx.GetTMNode()
configTimeoutPropose := tmNode.Config().Consensus.TimeoutPropose.Seconds()
Expand All @@ -76,11 +76,12 @@ func (s *TimeoutTestSuite) TestConfigTimeoutsOverride() {
assert.Equal(t, timeoutPropose.Seconds(), configTimeoutPropose)
assert.Equal(t, timeoutCommit.Seconds(), configTimeoutCommit)

// read the timeouts from the state at height 1 i.e., the genesis block
// read the timeouts from the state at height 1 i.e.,
//the state after applying the genesis file

Check failure on line 80 in app/test/timeouts_test.go

View workflow job for this annotation

GitHub Actions / lint / golangci-lint

commentFormatting: put a space between `//` and comment text (gocritic)
state1, err := s.cctx.GetTMNode().ConsensusStateTimeoutsByHeight(1)
require.NoError(t, err)

// state timeouts should not match the timeouts of the config
// state timeouts should NOT match the timeouts of the config
assert.True(t, configTimeoutPropose != state1.TimeoutPropose.Seconds())
assert.True(t, configTimeoutCommit != state1.TimeoutCommit.Seconds())

Expand Down

0 comments on commit b86606c

Please sign in to comment.