Ensure that MsgWirePayForData and MsgPayForData contain at least …

…one MessageShareCommitment (#654) * implement failing test * make test pass * implement failing test * make test pass
celestiaorg · Aug 28, 2022 · de5cd1d · de5cd1d
1 parent 301f9df
commit de5cd1d
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 0 deletions.
diff --git a/x/payment/types/errors.go b/x/payment/types/errors.go
@@ -18,4 +18,5 @@ var (
 	ErrTailPaddingNamespace           = sdkerrors.Register(ModuleName, 11118, "cannot use tail padding namespace ID")
 	ErrTxNamespace                    = sdkerrors.Register(ModuleName, 11119, "cannot use transaction namespace ID")
 	ErrEvidenceNamespace              = sdkerrors.Register(ModuleName, 11120, "cannot use evidence namespace ID")
+	ErrNoMessageShareCommitments      = sdkerrors.Register(ModuleName, 11121, "no message share commitments")
 )
diff --git a/x/payment/types/payfordata.go b/x/payment/types/payfordata.go
@@ -47,6 +47,10 @@ func (msg *MsgPayForData) ValidateBasic() error {
 		return err
 	}
 
+	if len(msg.MessageShareCommitment) == 0 {
+		return ErrNoMessageShareCommitments
+	}
+
 	return nil
 }
 

diff --git a/x/payment/types/payfordata_test.go b/x/payment/types/payfordata_test.go
@@ -357,6 +357,10 @@ func TestValidateBasic(t *testing.T) {
 	maxReservedNamespaceMsg := validMsgPayForData(t)
 	maxReservedNamespaceMsg.MessageNamespaceId = namespace.ID{0, 0, 0, 0, 0, 0, 0, 255}
 
+	// MsgPayForData that has no message share commitments
+	noMessageShareCommitments := validMsgPayForData(t)
+	noMessageShareCommitments.MessageShareCommitment = []byte{}
+
 	tests := []test{
 		{
 			name:    "valid msg",
@@ -393,6 +397,11 @@ func TestValidateBasic(t *testing.T) {
 			msg:     maxReservedNamespaceMsg,
 			wantErr: ErrReservedNamespace,
 		},
+		{
+			name:    "no message share commitments",
+			msg:     noMessageShareCommitments,
+			wantErr: ErrNoMessageShareCommitments,
+		},
 	}
 
 	for _, tt := range tests {

diff --git a/x/payment/types/wirepayfordata.go b/x/payment/types/wirepayfordata.go
@@ -118,6 +118,10 @@ func (msg *MsgWirePayForData) ValidateBasic() error {
 		}
 	}
 
+	if len(msg.MessageShareCommitment) == 0 {
+		return ErrNoMessageShareCommitments
+	}
+
 	return nil
 }
 

diff --git a/x/payment/types/wirepayfordata_test.go b/x/payment/types/wirepayfordata_test.go
@@ -49,6 +49,10 @@ func TestWirePayForData_ValidateBasic(t *testing.T) {
 	badSquareSizeMsg := validWirePayForData(t)
 	badSquareSizeMsg.MessageShareCommitment[0].K = 4
 
+	// pfd that signed over no squares
+	noMessageShareCommitments := validWirePayForData(t)
+	noMessageShareCommitments.MessageShareCommitment = []ShareCommitAndSignature{}
+
 	tests := []test{
 		{
 			name:    "valid msg",
@@ -95,6 +99,11 @@ func TestWirePayForData_ValidateBasic(t *testing.T) {
 			msg:     tailPaddingMsg,
 			wantErr: ErrTailPaddingNamespace,
 		},
+		{
+			name:    "no message share commitments",
+			msg:     noMessageShareCommitments,
+			wantErr: ErrNoMessageShareCommitments,
+		},
 	}
 
 	for _, tt := range tests {
-Original file line number
+Diff line change
@@ Expand Up / @@ -118,6 +118,10 @@ func (msg *MsgWirePayForData) ValidateBasic() error { @@
     		}
     	}
+    	if len(msg.MessageShareCommitment) == 0 {
+    		return ErrNoMessageShareCommitments
+    	}
     	return nil
     }
@@ Expand Down @@