Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misspelled words #2848

Closed
rootulp opened this issue Nov 16, 2023 · 3 comments
Closed

misspelled words #2848

rootulp opened this issue Nov 16, 2023 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@rootulp
Copy link
Collaborator

rootulp commented Nov 16, 2023

Context

https://goreportcard.com/report/github.com/celestiaorg/celestia-app

Problem

Screenshot 2023-11-16 at 10 18 01 AM

Proposal

  1. Fix the misspelled words
  2. Ensure that CI will fail if new misspelled words are added. We already have this enabled so it may require investigation
    - misspell
@rootulp rootulp added the good first issue Good for newcomers label Nov 16, 2023
@Caerlower
Copy link

Context

https://goreportcard.com/report/github.com/celestiaorg/celestia-app

Problem

Screenshot 2023-11-16 at 10 18 01 AM ## Proposal 1. Fix the misspelled words 2. Ensure that CI will fail if new misspelled words are added. We already have this enabled so it may require investigation https://github.com/celestiaorg/celestia-app/blob/fc03393dce943532c618da53069f9331fc575b1d/.golangci.yml#L9

I would like to do this issue can you assign this issue to me.

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 17, 2023

Nvm it looks like the previous report was based on a view of the codebase that was a year old. I refreshed the report via Refresh now and now there are no more reported spelling mistakes

Screenshot 2023-11-17 at 10 03 57 AM

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2023
@Caerlower
Copy link

Nvm it looks like the previous report was based on a view of the codebase that was a year old. I refreshed the report via Refresh now and now there are no more reported spelling mistakes

Screenshot 2023-11-17 at 10 03 57 AM

okay, thanks for assigning me the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants