-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix misspelled words #2852
Conversation
WalkthroughThe changes across various Go files in the Changes
Assessment against linked issues (Beta)
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (4)
- app/split_shares.go (2 hunks)
- x/payment/types/builder.go (1 hunks)
- x/payment/types/events.go (1 hunks)
- x/payment/types/payfordata.go (1 hunks)
Files skipped from review due to trivial changes (4)
- app/split_shares.go
- x/payment/types/builder.go
- x/payment/types/events.go
- x/payment/types/payfordata.go
Thanks for the contribution @Caerlower ! I updated the PR title to conform to convenitonal commits. See https://github.com/celestiaorg/celestia-app#contributing This PR has a few merge conflicts so do you mind fixing them? Also it would be helpful to understand why CI didn't catch these spellings mistakes earlier? Is there anything we can add to existing CI so that misspelled words get caught earlier? |
Yes, let me fix the merge conflicts. I checked the files but I didn't understand where this conflict might be arising from. There was one space which I removed can you please check if it's still getting problem? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- x/payment/types/events.go (1 hunks)
Files skipped from review due to trivial changes (1)
- x/payment/types/events.go
Ahh the merge conflicts arise b/c they're in files that have been deleted and/or moved. The typos are no longer an issue b/c #2848 (comment) Thanks for your interest @Caerlower ! We hope you continue contributing via other PRs! |
Okay, Thanks for assigning me the request. I will keep the learnings in mind to check before head if the codebase is old or new. |
Closes #2848
Summary by CodeRabbit
Bug Fixes
shareSplitter
logic to ensure at least one share is accounted for, enhancing the accuracy of share splitting functionality.Refactor
Documentation