Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure modules to be canononical and for readability #331

Closed
Tracked by #514
liamsi opened this issue Apr 15, 2022 · 2 comments
Closed
Tracked by #514

restructure modules to be canononical and for readability #331

liamsi opened this issue Apr 15, 2022 · 2 comments

Comments

@liamsi
Copy link
Member

liamsi commented Apr 15, 2022

Currently, we use the file and folder structure from startport. What we should be doing is rather using the recommended folder structure here: https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md#recommended-folder-structure

Where it helps readability we should deviate from that. I think Osmosis did a great job structuring their modules: https://github.com/osmosis-labs/osmosis/tree/main/x

A good opportunity to tackle this, would be when we upgrade to tendermint 0.35 and 0.46 of the SDK (related to celestiaorg/celestia-core#630 (comment)).

@evan-forbes
Copy link
Member

leaving a comment to remind us to also fix #472 (comment) when we address this issue

@evan-forbes evan-forbes self-assigned this Aug 8, 2022
@evan-forbes evan-forbes moved this from TODO to In Progress in Celestia Node Aug 8, 2022
@evan-forbes evan-forbes removed their assignment Nov 15, 2022
@rootulp
Copy link
Collaborator

rootulp commented Feb 21, 2024

Closing this because we have stand-alone modules in the x/ directory

@rootulp rootulp closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants