update to sdk v0.46.0 and downgrade tendermint to v0.34.20 #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
dependencies
Codecov Report
@@ Coverage Diff @@
## main #472 +/- ##
=======================================
Coverage ? 29.60%
=======================================
Files ? 16
Lines ? 2050
Branches ? 0
=======================================
Hits ? 607
Misses ? 1382
Partials ? 61 Help us with your feedback. Take ten seconds to tell us how you rate us. |
evan-forbes
changed the title
This was referenced Jul 27, 2022
Merged
Closed
Merged
4 tasks
liamsi
reviewed
Aug 1, 2022
rootulp
previously approved these changes
Aug 2, 2022
rach-id
previously approved these changes
Aug 2, 2022
Co-authored-by: Rootul Patel <[email protected]>
rootulp
approved these changes
Aug 3, 2022
rach-id
approved these changes
Aug 3, 2022
liamsi
approved these changes
Aug 5, 2022
Comment on lines
+632
to
+641
| func (app *App) setPostHanders() { | ||
| postHandler, err := posthandler.NewPostHandler( | ||
| posthandler.HandlerOptions{}, | ||
| ) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| app.SetPostHandler(postHandler) | ||
| } |
There was a problem hiding this comment.
that's a good point, I don't think it is, and we could put it this is normal typical definition of the app. tbh, I don't remember where I was going with this as the base of this PR is pretty old.
not changing for now simply so I don't dismiss the current approvals, but this should be fixed when we do #331
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pull the latest from tendermint and the cosmos-sdk. The changes introduced in the sdk are consensus breaking and will need to be included in the upcoming hardfork.
NOTE: the cosmos-sdk uses generics, so we also have to update to go 1.18. We can do that in a different PR instead of also doing it here.see #573