-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebuilt binaries are missing from -arabica
and -mocha
releases
#4033
Comments
v3.0.0-mocha goreleaser was skipped: https://github.com/celestiaorg/celestia-app/actions/runs/11680983880/job/33001958428. The workflow should run if a tag was pushed:
v2.3.1-mocha looks like it published a release to v2.3.1: https://github.com/celestiaorg/celestia-app/actions/runs/11596682388/job/32288420499#step:6:102 and not v2.3.1-mocha. v3.0.0-arabica failed to publish because it fetched the tag v3.0.0-rc0: https://github.com/celestiaorg/celestia-app/actions/runs/11479848124/job/31947080946#step:6:95 v2.3.0-mocha failed to publish because it fetched the tag v2.3.0: https://github.com/celestiaorg/celestia-app/actions/runs/11406322818/job/31739913197#step:6:69 |
Note: #3977 is present on v3.0.0-rc0, v3.0.0-mocha, v3.0.0-arabica. It is not present on v2.x releases so I think that's why tag fetching doesn't work as expected on v2.x. |
Manually published prebuilt binaries for the four releases linked in the OP. Will leave this open until we hear word back from GoReleaser on Discord. I realized that #3977 fetches the correct version (you can verify for your self via |
In the short term we can avoid this issue by ensuring that each release is for a unique commit. For example:
cc: @evan-forbes |
We should be able to override the current git tag via:
Ref: https://goreleaser.com/cookbooks/set-a-custom-git-tag/#setting-a-custom-git-tag |
Closes #4033 ## Testing On my fork v3.3.0-rc0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-rc0 v3.3.0-arabica: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-arabica v3.3.0-mocha: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-mocha v3.3.0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0 (cherry picked from commit 63c1e07)
Closes #4033 ## Testing On my fork v3.3.0-rc0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-rc0 v3.3.0-arabica: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-arabica v3.3.0-mocha: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-mocha v3.3.0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0<hr>This is an automatic backport of pull request #4044 done by [Mergify](https://mergify.com). Co-authored-by: Rootul P <[email protected]>
Closes #4033 ## Testing On my fork v3.3.0-rc0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-rc0 v3.3.0-arabica: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-arabica v3.3.0-mocha: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-mocha v3.3.0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0 (cherry picked from commit 63c1e07)
Context
#3926 which should've been fixed by #3929
Problem
These releases are missing prebuilt binaries:
Proposal
The text was updated successfully, but these errors were encountered: