fix: instruct GoReleaser to use current tag #4044
Conversation
|
On my fork:
Update: if we publish multiple releases near the same time, the GoReleaser action doesn't have time to run on each release prior to all tags being published so v31.0-arabica and v3.1.0-mocha prebuilt binaries weren't attached b/c the latest tag those actions saw was v3.1.0. Will retry testing but wait until the previous release has prebuilt binaries before creating the next release. |
Needed to retry testing on a fresh commit with no release tags
rootulp
requested review from
cmwaters,
rach-id,
evan-forbes and
ninabarbakadze
rootulp
added
the
backport:v3.x
📝 WalkthroughWalkthroughThe pull request introduces modifications to the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (3)Makefile (3)
The addition of
The changes maintain consistency with the Line range hint The current GIT_TAG priority order is:
Please verify this order aligns with your release strategy, particularly for handling Run this script to verify tag handling: ✅ Verification successfulLet me gather more information about the release strategy by checking the repository documentation. Let me check the actual tags in the repository to understand the versioning history and verify the priority order. Let me check the release documentation to understand the versioning strategy. Based on the release notes and documentation, I can now provide a final response about the tag priority order. The GIT_TAG priority order is correct and aligns with release strategy The current priority order in the Makefile:
This order correctly reflects Celestia's versioning strategy where:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify tag detection and priority order
# Test multiple tags pointing to the same commit
# Create a list of test tags in different orders
test_tags=(
"v3.3.0"
"v3.3.0-mocha"
"v3.3.0-arabica"
"v3.3.0-rc0"
)
# Show all tags that point to HEAD
echo "Current tags on HEAD:"
git tag --points-at HEAD
# Test tag priority logic
echo -e "\nTesting tag priority with pattern matching:"
for pattern in \
'^v[0-9]+\.[0-9]+\.[0-9]+$' \
'^v[0-9]+\.[0-9]+\.[0-9]+-mocha$' \
'^v[0-9]+\.[0-9]+\.[0-9]+-arabica$' \
'^v[0-9]+\.[0-9]+\.[0-9]+-rc[0-9]*$'; do
echo "Pattern: $pattern"
git tag --points-at HEAD --sort=-v:refname | grep -E "$pattern" || echo "No matching tag"
done
Length of output: 1739 Script: #!/bin/bash
# Check documentation for release strategy
echo "=== Checking README.md for release info ==="
fd -t f "README.md" -X cat
echo -e "\n=== Checking docs directory for release info ==="
fd -t f -e md "release" docs/ -X cat || true
echo -e "\n=== Checking for CHANGELOG.md ==="
fd -t f "CHANGELOG.md" -X cat || true
echo -e "\n=== List all tags to understand versioning history ==="
git tag -l | sort -V | tail -n 10
Length of output: 102531 Script: #!/bin/bash
# List all tags sorted by version and filter for different types
echo "=== All tags sorted by version ==="
git tag -l | sort -V
echo -e "\n=== Mocha tags ==="
git tag -l | grep -E "v[0-9]+\.[0-9]+\.[0-9]+-mocha"
echo -e "\n=== Arabica tags ==="
git tag -l | grep -E "v[0-9]+\.[0-9]+\.[0-9]+-arabica"
echo -e "\n=== RC tags ==="
git tag -l | grep -E "v[0-9]+\.[0-9]+\.[0-9]+-rc[0-9]+"
echo -e "\n=== Beta tags ==="
git tag -l | grep -E "v[0-9]+\.[0-9]+\.[0-9]+-beta"
echo -e "\n=== Alpha tags ==="
git tag -l | grep -E "v[0-9]+\.[0-9]+\.[0-9]+-alpha"
Length of output: 641 Script: #!/bin/bash
# Check release guide for versioning strategy
echo "=== Checking release guide ==="
cat docs/release-guide.md
echo -e "\n=== Checking release notes ==="
cat docs/release-notes/release-notes.md
# Try a different approach to list tags
echo -e "\n=== List tags with git for-each-ref ==="
git for-each-ref --sort=creatordate --format '%(refname:short)' refs/tags/
Length of output: 4780 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Closes #4033 ## Testing On my fork v3.3.0-rc0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-rc0 v3.3.0-arabica: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-arabica v3.3.0-mocha: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-mocha v3.3.0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0 (cherry picked from commit 63c1e07)
Closes #4033 ## Testing On my fork v3.3.0-rc0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-rc0 v3.3.0-arabica: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-arabica v3.3.0-mocha: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-mocha v3.3.0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0<hr>This is an automatic backport of pull request #4044 done by [Mergify](https://mergify.com). Co-authored-by: Rootul P <[email protected]>
Closes #4033 ## Testing On my fork v3.3.0-rc0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-rc0 v3.3.0-arabica: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-arabica v3.3.0-mocha: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-mocha v3.3.0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0 (cherry picked from commit 63c1e07)
Closes #4033
Testing
On my fork
v3.3.0-rc0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-rc0
v3.3.0-arabica: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-arabica
v3.3.0-mocha: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0-mocha
v3.3.0: https://github.com/rootulp/celestia-app/releases/tag/v3.3.0