Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Parameter picking Tracking issue #669

Closed
9 tasks done
Tracked by #514
evan-forbes opened this issue Aug 26, 2022 · 3 comments
Closed
9 tasks done
Tracked by #514

EPIC: Parameter picking Tracking issue #669

evan-forbes opened this issue Aug 26, 2022 · 3 comments
Labels
epic item groups other items for easier tracking

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Aug 26, 2022

We need to do a lot of investigation based work in order to ensure that we pick correct parameters. This will involve individuals selecting specific sets of parameters, doing some investigation, including performing preliminary network tests, and summarizing this work for comment on other teams. Our goal is to have an official list of parameters decided on by the end of onsite, where we will discuss the params and their respective investigations synchronously.

@evan-forbes
Copy link
Member Author

In our giant param call, we came to a few decisions that we can track here as well.

Mempool Config Defaults

  • Decided
    • We’re planning on using v1 (prioritized by fee) as a default
    • Its up to validators to modify PrepareProposal to incorporate further ordering
    • Implement a blocklist for the mempool reactor
    • Change the default of the max transaction size accepted to something closer to the max block size
  • Undecided
    • default minimum fee in app.toml

RPC Config

  • Decided
    • change the default broadcast-timeout-commit to something roughly double the suspected block time
    • Increase the default max body bytes

Genesis Params

  • Consensus
    • Decided
      • We are not going to use TimeIotaMs to regulate the block time during consensus
      • We have to manually calculate the values for Evidence (time per year / number of blocks per year
  • Auth
    • Decided
      • We are leaving the default auth ante handler costs as the default
        • 590 gas per sig
        • 10 Gas per byte for each tx
    • Undecided
      • We might want to decrease the max memo size
  • Distribution
    • Decided
      • we will leave WithdrawAddrEnabled
    • Undecided
      • Exact values for community tax, base proposer, and bonus proposer reward
  • Mint
    • Decided
      • we want a lower value for inflation
      • we want to set inflation max and inflation min to the same value
    • Undecided
      • the exact values for inflation are tbd
    • Todo
      • lookup what annual provisions are
  • Slashing
    • Decided
      • signed blocks window will be increased to roughly a day
    • Undecided
      • exact percentage from slash fraction
  • Staking
    • Decided
      • set the min commission to 5%
    • Undecided
      • The exact value to unbonding time: currently 21 days

Gas

  • Decided
    • We still need a more comprehensive examination of the resource pricing
      • We will create a deliverable to document the exact gas used and how its calculated for standard txs in the specs
    • We will add two new constants for gas consumed by PFDs
      • Base gas
      • per byte multiplier
      • We want to increase the initial per byte gas cost to 8 and base cost to 0

@evan-forbes
Copy link
Member Author

we should also fix celestiaorg/cosmos-sdk#283

before closing this issue

rootulp added a commit that referenced this issue Nov 16, 2022
Addresses
#669 (comment)
by copying the consensus config overrides from celestiaorg/cosmos-sdk.

This PR should be merged in parallel with
celestiaorg/cosmos-sdk#284

Co-authored-by: Evan Forbes <[email protected]>
@evan-forbes evan-forbes changed the title Parameter picking Tracking issue EPIC: Parameter picking Tracking issue Nov 17, 2022
@evan-forbes evan-forbes moved this to Todo in Core / App Epics Nov 17, 2022
@evan-forbes evan-forbes moved this to In Progress in Engineering Team Epics Nov 17, 2022
@evan-forbes evan-forbes moved this from Todo to In Progress in Core / App Epics Nov 17, 2022
@evan-forbes evan-forbes added this to the Q4 2022 milestone Nov 17, 2022
rach-id pushed a commit to rach-id/celestia-app that referenced this issue Nov 17, 2022
Addresses
celestiaorg#669 (comment)
by copying the consensus config overrides from celestiaorg/cosmos-sdk.

This PR should be merged in parallel with
celestiaorg/cosmos-sdk#284

Co-authored-by: Evan Forbes <[email protected]>
@evan-forbes evan-forbes removed this from the Q4 2022 milestone Dec 8, 2022
evan-forbes added a commit that referenced this issue Dec 8, 2022
Addresses
#669 (comment)
by copying the consensus config overrides from celestiaorg/cosmos-sdk.

This PR should be merged in parallel with
celestiaorg/cosmos-sdk#284

Co-authored-by: Evan Forbes <[email protected]>
@evan-forbes evan-forbes removed their assignment Feb 7, 2023
@evan-forbes evan-forbes moved this from In Progress to Done in Engineering Team Epics Jul 10, 2023
@evan-forbes
Copy link
Member Author

can close since all parameters have been chosen

@github-project-automation github-project-automation bot moved this from In Progress to Done in Core / App Epics Jul 10, 2023
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
Addresses
celestiaorg/celestia-app#669 (comment)
by copying the consensus config overrides from celestiaorg/cosmos-sdk.

This PR should be merged in parallel with
celestiaorg/cosmos-sdk#284

Co-authored-by: Evan Forbes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic item groups other items for easier tracking
Projects
Status: Done
Development

No branches or pull requests

4 participants