Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tendermint consensus config overrides #1012

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 16, 2022

Addresses #669 (comment) by copying the consensus config overrides from celestiaorg/cosmos-sdk.

This PR should be merged in parallel with celestiaorg/cosmos-sdk#284

Moved from celestiaorg/cosmos-sdk
@rootulp rootulp self-assigned this Nov 16, 2022
@rootulp rootulp marked this pull request as ready for review November 16, 2022 01:29
@rootulp rootulp requested a review from evan-forbes as a code owner November 16, 2022 01:29
@codecov-commenter
Copy link

Codecov Report

Merging #1012 (1a6277e) into main (f67acce) will increase coverage by 23.93%.
The diff coverage is 44.44%.

@@             Coverage Diff             @@
##             main    #1012       +/-   ##
===========================================
+ Coverage   27.15%   51.09%   +23.93%     
===========================================
  Files          81       71       -10     
  Lines        9021     4378     -4643     
===========================================
- Hits         2450     2237      -213     
+ Misses       6335     1915     -4420     
+ Partials      236      226       -10     
Impacted Files Coverage Δ
x/blob/keeper/keeper.go 91.30% <ø> (ø)
x/blob/types/params.go 33.33% <28.57%> (-3.71%) ⬇️
x/blob/keeper/params.go 100.00% <100.00%> (ø)
x/blob/types/params.pb.go
x/blob/types/query.pb.go
x/blob/types/genesis.pb.go
x/blob/types/tx.pb.go
x/qgb/types/query.pb.go
x/qgb/types/types.pb.go
x/qgb/types/genesis.pb.go
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one update

cmd/celestia-appd/cmd/root.go Outdated Show resolved Hide resolved
@rootulp rootulp requested a review from evan-forbes November 16, 2022 15:51
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evan-forbes evan-forbes linked an issue Nov 16, 2022 that may be closed by this pull request
@rootulp rootulp merged commit 778a18e into celestiaorg:main Nov 16, 2022
@rootulp rootulp deleted the rp/move-cosmos-sdk-config-overrides branch November 16, 2022 19:02
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 17, 2022
Addresses
celestiaorg#669 (comment)
by copying the consensus config overrides from celestiaorg/cosmos-sdk.

This PR should be merged in parallel with
celestiaorg/cosmos-sdk#284

Co-authored-by: Evan Forbes <[email protected]>
evan-forbes added a commit that referenced this pull request Dec 8, 2022
Addresses
#669 (comment)
by copying the consensus config overrides from celestiaorg/cosmos-sdk.

This PR should be merged in parallel with
celestiaorg/cosmos-sdk#284

Co-authored-by: Evan Forbes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config/consensus: define default parameters
3 participants