Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate network testing code #829

Closed
2 tasks
Tracked by #1256
evan-forbes opened this issue Oct 3, 2022 · 4 comments · Fixed by #3118
Closed
2 tasks
Tracked by #1256

Consolidate network testing code #829

evan-forbes opened this issue Oct 3, 2022 · 4 comments · Fixed by #3118
Assignees
Labels
good first issue Good for newcomers testing items that are strictly related to adding or extending test coverage

Comments

@evan-forbes
Copy link
Member

With the introduction of our own network tests, we should replace our usage of the old cosmos-sdk network tests for our integration tests.

This will involve:

  • Adding cli execution functionality for the new testnode
  • Refactor existing integration tests to use new testnode

we should also expect a decrease in integration test times, since the new testnode can produce sub 1s blocks.

@evan-forbes evan-forbes added good first issue Good for newcomers C: Celestia app testing items that are strictly related to adding or extending test coverage labels Oct 3, 2022
@evan-forbes evan-forbes moved this to TODO in Celestia Node Oct 3, 2022
@rootulp
Copy link
Collaborator

rootulp commented Oct 10, 2022

Resolving this issue will likely also resolve #574

@rahulghangas
Copy link
Contributor

Picking this up

@evan-forbes
Copy link
Member Author

in #1474, we are introducing the ibctesting framework for testing the ibc token filter. This seems like a good solution imo considering the amount of work we'd have to do replicate the same functionality. However, I'll ref it here to have a more exhaustive list

@evan-forbes evan-forbes removed this from the Mainnet milestone Apr 2, 2023
@rootulp
Copy link
Collaborator

rootulp commented Nov 25, 2023

I think the original post refers to the two test networks:
A.

func New(t *testing.T, config network.Config, genAccNames ...string) *network.Network {

B.
func NewNetwork(t testing.TB, cfg *Config) (cctx Context, rpcAddr, grpcAddr string) {

where A should be deleted and usage of A should be replaced with B.

@cmwaters cmwaters self-assigned this Feb 21, 2024
cmwaters added a commit that referenced this issue Feb 22, 2024
Closes: #829

This refactors the three tests we have that use the CLI commands:
`mint`, `blob` and `blobstream` to use the `testnode` package instead of
`cosmos-sdk`'s `network` package.

The motivating reason for this is that cosmos-sdk's network package
doesn't support initialising the `ConsensusParams` in the genesis file
which we need to set the app version correctly

---------

Co-authored-by: Rootul P <[email protected]>
@github-project-automation github-project-automation bot moved this from TODO to Done in Celestia Node Feb 22, 2024
ninabarbakadze pushed a commit to ninabarbakadze/celestia-app that referenced this issue Apr 2, 2024
…g#3118)

Closes: celestiaorg#829

This refactors the three tests we have that use the CLI commands:
`mint`, `blob` and `blobstream` to use the `testnode` package instead of
`cosmos-sdk`'s `network` package.

The motivating reason for this is that cosmos-sdk's network package
doesn't support initialising the `ConsensusParams` in the genesis file
which we need to set the app version correctly

---------

Co-authored-by: Rootul P <[email protected]>
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
Closes: celestiaorg/celestia-app#829

This refactors the three tests we have that use the CLI commands:
`mint`, `blob` and `blobstream` to use the `testnode` package instead of
`cosmos-sdk`'s `network` package.

The motivating reason for this is that cosmos-sdk's network package
doesn't support initialising the `ConsensusParams` in the genesis file
which we need to set the app version correctly

---------

Co-authored-by: Rootul P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing items that are strictly related to adding or extending test coverage
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants