-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate network testing code #829
Comments
Resolving this issue will likely also resolve #574 |
Picking this up |
in #1474, we are introducing the ibctesting framework for testing the ibc token filter. This seems like a good solution imo considering the amount of work we'd have to do replicate the same functionality. However, I'll ref it here to have a more exhaustive list |
I think the original post refers to the two test networks: celestia-app/test/util/network/network.go Line 27 in be3acf0
B.
where A should be deleted and usage of A should be replaced with B. |
Closes: #829 This refactors the three tests we have that use the CLI commands: `mint`, `blob` and `blobstream` to use the `testnode` package instead of `cosmos-sdk`'s `network` package. The motivating reason for this is that cosmos-sdk's network package doesn't support initialising the `ConsensusParams` in the genesis file which we need to set the app version correctly --------- Co-authored-by: Rootul P <[email protected]>
…g#3118) Closes: celestiaorg#829 This refactors the three tests we have that use the CLI commands: `mint`, `blob` and `blobstream` to use the `testnode` package instead of `cosmos-sdk`'s `network` package. The motivating reason for this is that cosmos-sdk's network package doesn't support initialising the `ConsensusParams` in the genesis file which we need to set the app version correctly --------- Co-authored-by: Rootul P <[email protected]>
Closes: celestiaorg/celestia-app#829 This refactors the three tests we have that use the CLI commands: `mint`, `blob` and `blobstream` to use the `testnode` package instead of `cosmos-sdk`'s `network` package. The motivating reason for this is that cosmos-sdk's network package doesn't support initialising the `ConsensusParams` in the genesis file which we need to set the app version correctly --------- Co-authored-by: Rootul P <[email protected]>
With the introduction of our own network tests, we should replace our usage of the old cosmos-sdk network tests for our integration tests.
This will involve:
we should also expect a decrease in integration test times, since the new testnode can produce sub 1s blocks.
The text was updated successfully, but these errors were encountered: