Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase retries and block times in integration test for CI #988

Closed
wants to merge 1 commit into from

Conversation

evan-forbes
Copy link
Member

trying some things out to reduce flakiness of CI as its getting extremely annoying

@codecov-commenter
Copy link

Codecov Report

Merging #988 (11f352e) into main (29e0a27) will increase coverage by 3.61%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
+ Coverage   26.13%   29.74%   +3.61%     
==========================================
  Files          77       72       -5     
  Lines        9353     8199    -1154     
==========================================
- Hits         2444     2439       -5     
+ Misses       6680     5531    -1149     
  Partials      229      229              
Impacted Files Coverage Δ
app/app.go 6.49% <ø> (ø)
x/payment/types/events.go 0.00% <ø> (ø)
x/qgb/handler.go 0.00% <0.00%> (ø)
x/qgb/module.go 7.27% <ø> (+0.12%) ⬆️
x/qgb/types/codec.go 0.00% <ø> (ø)
x/qgb/types/genesis.pb.go 1.13% <ø> (ø)
x/qgb/types/query.pb.go 0.86% <ø> (ø)
pkg/shares/split_sparse_shares.go 70.00% <25.00%> (+2.03%) ⬆️
app/estimate_square_size.go 81.94% <100.00%> (ø)
x/payment/keeper/keeper.go 64.70% <100.00%> (+2.20%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evan-forbes
Copy link
Member Author

evan-forbes commented Nov 9, 2022

one of the things that is causing issues is that the mempool is full when we submit txs. We don't have access to the full tendermint config needed to increase it until we switch to our own proprietary integration test code. cc @sweexordious

#829

@rach-id
Copy link
Member

rach-id commented Nov 9, 2022

Aah makes sense. Thanks 👍

@rahulghangas
Copy link
Contributor

I'll create the relevant PR to close #829 today

@evan-forbes
Copy link
Member Author

closing this, but we might want to incorporate something similar when we are refactoring the testing in #829

@rootulp rootulp deleted the evan/less-flakey-integration-test branch July 23, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants