Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use a single transaction builder #175

Merged
merged 15 commits into from
Jan 14, 2022

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Jan 7, 2022

Description

This PR:

blocked by #171

closes: #144

@evan-forbes evan-forbes self-assigned this Jan 7, 2022
@evan-forbes evan-forbes marked this pull request as ready for review January 10, 2022 21:09
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict.

@evan-forbes evan-forbes force-pushed the evan/tx-builder-refactor branch from 94ef986 to f3cc203 Compare January 13, 2022 20:56
@adlerjohn adlerjohn linked an issue Jan 13, 2022 that may be closed by this pull request
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-target against master?

@evan-forbes
Copy link
Member Author

evan-forbes commented Jan 14, 2022

Re-target against master?

oh shoot, I thought it auto re-target since we merged #171...

retargeting, thanks!

@evan-forbes evan-forbes changed the base branch from evan/integration-test to master January 14, 2022 00:41
dependabot bot added 3 commits January 13, 2022 18:42
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](goreleaser/goreleaser-action@v2.7.0...v2.8.0)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/celestiaorg/nmt](https://github.com/celestiaorg/nmt) from 0.7.0 to 0.8.0.
- [Release notes](https://github.com/celestiaorg/nmt/releases)
- [Commits](celestiaorg/nmt@v0.7.0...v0.8.0)

---
updated-dependencies:
- dependency-name: github.com/celestiaorg/nmt
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A wild merge conflict appears

Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green checkmark means go

@evan-forbes evan-forbes merged commit b4c8ebd into master Jan 14, 2022
@liamsi liamsi deleted the evan/tx-builder-refactor branch January 30, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Refactor to stop using the txbuilder more than once
2 participants