Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use testnode instead of cosmos-sdk version #1904

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

evan-forbes
Copy link
Member

Overview

minor refactor of one of our integration tests to use testnode instead of the cosmos-sdk's version.

part of #832

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes added the testing items that are strictly related to adding or extending test coverage label Jun 11, 2023
@evan-forbes evan-forbes self-assigned this Jun 11, 2023
@MSevey MSevey requested a review from a team June 11, 2023 21:00
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2023

Codecov Report

Merging #1904 (0719738) into main (0629c75) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1904   +/-   ##
=======================================
  Coverage   21.85%   21.85%           
=======================================
  Files         117      117           
  Lines       13304    13304           
=======================================
  Hits         2907     2907           
  Misses      10107    10107           
  Partials      290      290           

@evan-forbes evan-forbes requested a review from rach-id June 12, 2023 02:03
@evan-forbes evan-forbes merged commit c00cf27 into main Jun 13, 2023
@evan-forbes evan-forbes deleted the evan/consolidate-integration-test branch June 13, 2023 22:29
evan-forbes added a commit that referenced this pull request Jun 14, 2023
* refactor: use testnode instead of cosmos-sdk version

* chore: linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants