Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add square sizes flag to the payForMessage cli command #202

Merged
merged 25 commits into from
Feb 14, 2022
Merged

Add square sizes flag to the payForMessage cli command #202

merged 25 commits into from
Feb 14, 2022

Conversation

toanngosy
Copy link
Contributor

Description

closes: #180

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@toanngosy toanngosy marked this pull request as ready for review February 7, 2022 08:45
evan-forbes
evan-forbes requested changes Feb 7, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this on! please let me know if you have any questions 🙂

app/abci.go Outdated Show resolved Hide resolved
app/abci.go Outdated Show resolved Hide resolved
flags/flags.go Outdated Show resolved Hide resolved
@evan-forbes evan-forbes changed the title Square sizes Add square sizes flag to the payForMessage cli command Feb 7, 2022
@adlerjohn adlerjohn added the enhancement New feature or request label Feb 12, 2022
evan-forbes
evan-forbes reviewed Feb 13, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there!!

I know some of these are kinda nit picky, but these small things add up quickly, especially for future readers of the code.

Thanks for continually incorporating this feedback! We're very close!

flags/flags.go Outdated Show resolved Hide resolved
x/payment/client/cli/wirepayformessage.go Outdated Show resolved Hide resolved
x/payment/client/testutil/integration_test.go Outdated Show resolved Hide resolved
x/payment/types/wirepayformessage.go Outdated Show resolved Hide resolved
evan-forbes
evan-forbes previously approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: almost perfect, thanks for this! 🚀

@evan-forbes evan-forbes dismissed their stale review February 13, 2022 21:45

missed a failing test, almost there though

@evan-forbes evan-forbes merged commit 7834655 into celestiaorg:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@adlerjohn adlerjohn

@evan-forbes evan-forbes

Labels
enhancement New feature or request
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cli flag to specify specific square sizes
3 participants
@toanngosy @evan-forbes @adlerjohn