feat: add the ability to specifiy the txsim master account #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
approved these changes
Aug 17, 2023
rach-id
approved these changes
Aug 17, 2023
cmwaters
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
LGTM. We might be getting to the stage where we want to start using the options paradigm (or even having a config). masterAccName, seed and pollTime all have defaults and don't need to be set. Arguably grpcEndpoints and rpcEndpoints also have default values. This may make the constructor a bit more tidy and allow us to continue adding options in the future
yeah I was thinking the same thing. a config would be more readable to me than a bash script with 10 flags lol |
evan-forbes
added
the
backport:v1.x
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
## Overview This PR adds the ability to specify a specific account to use as master for txsim. This is useful for when we don't want to always use the account with the most funds in our wallet. closes #2286 kinda sorta blocking #2197 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords (cherry picked from commit 2102189) # Conflicts: # test/e2e/simple_test.go
I think the devops folks will want flags all the way :) |
evan-forbes
added a commit
that referenced
this pull request
Aug 17, 2023
…2292) (#2299) This is an automatic backport of pull request #2292 done by [Mergify](https://mergify.com). Cherry-pick of 2102189 has failed: ``` On branch mergify/bp/v1.x/pr-2292 Your branch is up to date with 'origin/v1.x'. You are currently cherry-picking commit 2102189. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: app/test/square_size_test.go modified: test/cmd/txsim/cli.go modified: test/txsim/account.go modified: test/txsim/run.go modified: test/txsim/run_test.go Unmerged paths: (use "git add/rm <file>..." as appropriate to mark resolution) deleted by us: test/e2e/simple_test.go ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: Evan Forbes <[email protected]> Co-authored-by: evan-forbes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the ability to specify a specific account to use as master for txsim. This is useful for when we don't want to always use the account with the most funds in our wallet.
closes #2286
kinda sorta blocking #2197
Checklist