Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics to prepare and process proposal (backport #2560) #2564

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 21, 2023

This is an automatic backport of pull request #2560 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Closes: #2517

This PR adds metrics to track:
- The amount of times process proposal recovers from a panic
- The amount of invalid transactions that get filtered in prepare
proposal
- The time it takes for prepare proposal and process proposal to execute

(cherry picked from commit 5682d2c)
@github-actions github-actions bot added the bot item was created by a bot label Sep 21, 2023
@celestia-bot celestia-bot requested a review from a team September 21, 2023 15:28
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #2564 (fd77903) into v1.x (e08ead2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             v1.x    #2564      +/-   ##
==========================================
- Coverage   20.37%   20.36%   -0.01%     
==========================================
  Files         138      138              
  Lines       15902    15907       +5     
==========================================
  Hits         3240     3240              
- Misses      12354    12359       +5     
  Partials      308      308              
Files Changed Coverage Δ
app/prepare_proposal.go 0.00% <0.00%> (ø)
app/process_proposal.go 0.00% <0.00%> (ø)
app/validate_txs.go 0.00% <0.00%> (ø)

@celestia-bot celestia-bot requested a review from a team September 22, 2023 07:54
@evan-forbes evan-forbes enabled auto-merge (squash) September 22, 2023 13:40
@evan-forbes evan-forbes merged commit c33a188 into v1.x Sep 22, 2023
22 checks passed
@evan-forbes evan-forbes deleted the mergify/bp/v1.x/pr-2560 branch September 22, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants