chore!: remove MinShareCount constant
#2566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chirag018
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2566 +/- ##
==========================================
+ Coverage 20.63% 20.66% +0.03%
==========================================
Files 133 133
Lines 15346 15349 +3
==========================================
+ Hits 3166 3172 +6
+ Misses 11877 11875 -2
+ Partials 303 302 -1
|
rootulp
changed the title
MinShareCount constant
rootulp
requested changes
Sep 21, 2023
rootulp
added
the
warn:api breaking
|
Thanks for the PR @Chirag018 ! I don't think we want to include any more breaking changes in v1.x. so we may not end up merging this |
rootulp
reviewed
Sep 21, 2023
staheri14
reviewed
Sep 27, 2023
| return shares.TailPaddingShares(appconsts.MinShareCount) | ||
| // minShareCount is the minimum number of shares allowed in the original | ||
| // data square. | ||
| minShareCount := appconsts.MinSquareSize*appconsts.MinSquareSize |
There was a problem hiding this comment.
[Optional Suggestion] If we anticipate that the minimum share count might be utilized beyond the scope of the EmptySquare, it could be advantageous to create a dedicated function, such as MinShareCount().
evan-forbes
approved these changes
Sep 27, 2023
|
Sorry @Chirag018 I assume we didn't merge this to avoid last minute breaking changes in the v1.x release. Given the low-ish priority of #1183, I think we should close the issue as won't do for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1183