-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: increase MinDeposit
from 1K to 10K TIA
#2631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chirag018
requested review from
liamsi,
adlerjohn,
evan-forbes,
rootulp and
cmwaters
as code owners
October 7, 2023 19:33
Codecov Report
@@ Coverage Diff @@
## main #2631 +/- ##
==========================================
+ Coverage 20.61% 20.63% +0.01%
==========================================
Files 132 132
Lines 15338 15338
==========================================
+ Hits 3162 3165 +3
+ Misses 11872 11870 -2
+ Partials 304 303 -1
|
Chirag018
changed the title
fix: increase MinDeposit from 1K to 10K TIA
chore: increase MinDeposit from 1K to 10K TIA
Oct 8, 2023
evan-forbes
reviewed
Oct 8, 2023
rootulp
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Chirag018 ! We don't have consensus yet on #2629 so we'll hold off on merging until we have alignment on the GH issue
rootulp
requested changes
Oct 10, 2023
rootulp
added
the
backport:v1.x
PR will be backported automatically to the v1.x branch upon merging
label
Oct 10, 2023
rootulp
requested changes
Oct 10, 2023
rootulp
changed the title
chore: increase MinDeposit from 1K to 10K TIA
chore: increase Oct 10, 2023
MinDeposit
from 1K to 10K TIA
rootulp
approved these changes
Oct 10, 2023
cmwaters
approved these changes
Oct 11, 2023
evan-forbes
approved these changes
Oct 11, 2023
rootulp
pushed a commit
that referenced
this pull request
Oct 12, 2023
This is an automatic backport of pull request #2631 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Chirag <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2629