Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: increase MinDeposit from 1K to 10K TIA #2631

Merged
merged 7 commits into from
Oct 11, 2023
Merged

chore: increase MinDeposit from 1K to 10K TIA #2631

merged 7 commits into from
Oct 11, 2023

Conversation

Chirag018
Copy link
Contributor

Closes #2629

@celestia-bot celestia-bot requested a review from a team October 7, 2023 19:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023 •
edited
Loading

Codecov Report

Merging #2631 (1209c36) into main (1fee9de) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2631      +/-   ##
==========================================
+ Coverage   20.61%   20.63%   +0.01%     
==========================================
  Files         132      132              
  Lines       15338    15338              
==========================================
+ Hits         3162     3165       +3     
+ Misses      11872    11870       -2     
+ Partials      304      303       -1
Files Coverage Δ
app/default_overrides.go 15.10% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Chirag018 Chirag018 changed the title fix: increase MinDeposit from 1K to 10K TIA chore: increase MinDeposit from 1K to 10K TIA Oct 8, 2023
rootulp
rootulp requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Chirag018 ! We don't have consensus yet on #2629 so we'll hold off on merging until we have alignment on the GH issue

test/util/testnode/genesis_options.go Outdated Show resolved Hide resolved
specs/src/specs/params.md Outdated Show resolved Hide resolved
app/default_overrides.go Outdated Show resolved Hide resolved
@celestia-bot celestia-bot requested a review from a team October 9, 2023 15:57
rootulp
rootulp requested changes Oct 10, 2023
View reviewed changes
app/default_overrides.go Outdated Show resolved Hide resolved
app/default_overrides_test.go Outdated Show resolved Hide resolved
specs/src/specs/params.md Outdated Show resolved Hide resolved
@rootulp rootulp added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Oct 10, 2023
@celestia-bot celestia-bot requested a review from a team October 10, 2023 14:42
rootulp
rootulp requested changes Oct 10, 2023
View reviewed changes
specs/src/specs/params.md Outdated Show resolved Hide resolved
specs/src/specs/params.md Outdated Show resolved Hide resolved
@celestia-bot celestia-bot requested a review from a team October 10, 2023 17:59
@Chirag018 Chirag018 requested a review from rootulp October 10, 2023 18:14
@rootulp rootulp changed the title chore: increase MinDeposit from 1K to 10K TIA chore: increase MinDeposit from 1K to 10K TIA Oct 10, 2023
@rootulp rootulp requested a review from evan-forbes October 10, 2023 18:19
@evan-forbes evan-forbes merged commit 91f6024 into celestiaorg:main Oct 11, 2023
24 checks passed
mergify bot pushed a commit that referenced this pull request Oct 11, 2023
@Chirag018 @mergify
chore: increase MinDeposit from 1K to 10K TIA (#2631)
0e88689 
Closes #2629

(cherry picked from commit 91f6024)
@mergify mergify bot mentioned this pull request Oct 11, 2023
Merged
rootulp pushed a commit that referenced this pull request Oct 12, 2023
@mergify @Chirag018
chore: increase MinDeposit from 1K to 10K TIA (backport #2631) (#2660)
f2e5bce 
This is an automatic backport of pull request #2631 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Chirag <[email protected]>
@Chirag018 Chirag018 deleted the increase-deposit branch October 15, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@cmwaters cmwaters cmwaters approved these changes

@rootulp rootulp rootulp approved these changes

@liamsi liamsi Awaiting requested review from liamsi

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

Assignees

@Chirag018 Chirag018

Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase MinDeposit from 1K to 10K TIA
5 participants
@Chirag018 @codecov-commenter @rootulp @cmwaters @evan-forbes