Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LatestAttestationNonce constant name typo #2646

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix: LatestAttestationNonce constant name typo #2646

merged 2 commits into from
Oct 10, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Oct 10, 2023

Overview

Fixes typo

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the typo label Oct 10, 2023
@rach-id rach-id self-assigned this Oct 10, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner October 10, 2023 11:31
@celestia-bot celestia-bot requested review from a team and staheri14 and removed request for a team October 10, 2023 11:31
@codecov-commenter
Copy link

Codecov Report

Merging #2646 (aae155b) into main (3722119) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2646   +/-   ##
=======================================
  Coverage   20.62%   20.62%           
=======================================
  Files         133      133           
  Lines       15345    15345           
=======================================
  Hits         3165     3165           
  Misses      11877    11877           
  Partials      303      303           
Files Coverage Δ
x/qgb/keeper/keeper_attestation.go 66.66% <100.00%> (ø)
x/qgb/types/keys.go 0.00% <ø> (ø)

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol good catch

@rach-id rach-id added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Oct 10, 2023
@rach-id rach-id enabled auto-merge (squash) October 10, 2023 19:07
@celestia-bot celestia-bot requested a review from a team October 10, 2023 19:07
@rach-id rach-id merged commit 0e1fa70 into main Oct 10, 2023
28 checks passed
@rach-id rach-id deleted the typo-fixc branch October 10, 2023 19:22
mergify bot pushed a commit that referenced this pull request Oct 10, 2023
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Fixes typo

## Checklist

<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

(cherry picked from commit 0e1fa70)
rach-id added a commit that referenced this pull request Oct 11, 2023
This is an automatic backport of pull request #2646 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: CHAMI Rachid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants